-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce group_replica partial response strategy #33
Conversation
89aa401
to
d5b25f5
Compare
ae27eeb
to
d330354
Compare
d330354
to
2259d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice, just a few small comments, do we have any tests to see how this behaves? Also, please make sure e2e tests pass to avoid regressions
some end-to-end tests are flaky on db_main. |
Signed-off-by: HC Zhu (Databricks) <[email protected]>
Signed-off-by: HC Zhu (Databricks) <[email protected]>
a4e03c4
to
de6ff4c
Compare
cd0c292
to
ae79e3f
Compare
ae79e3f
to
3e96d0d
Compare
This is to implement the idea in https://docs.google.com/document/d/1eGoUFNGq2pOhmQH_svBkUZ45ig8bVOZH6xi9wkNRN_E/edit#heading=h.axx9hx8o4mz5
This strategy takes effect only when the partial response tolerance flag is off. Therefore, by default, this strategy is off.
Tested the image in
dev-aws-eu-west-1
without turning on the new strategy.How does the new strategy work?
endpoint
specifies multiple DNS names, likednssrv+db-rep0:9092
,dnssrv+db-rep1:9092
, anddnssrv+range-store:9092